[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2894:
---------------------------
Attachment: SOLR-2894.patch
bq. Quick note on PivotFacetHelper's retrieve method ...
I haven't really been aware of those other issues until now (although SOLR-3583
may explain some of the unused code i pruned from PivotListEntry a few patches
ago) but i agree with your assessment: if/when enhancements to distributed
pivots start dealing with adding optional data to each level of the pivot, the
appraoch currently used will have to change.
(Personally: I'm not emotionally ready to put any serious thought into that
level of implementation detail in future pivot improvements - i want to focus
on getting the basics of distrib pivots solid & released first)
----
Updated patch with most of the tests i had in mind that i mentioned before
(although i'd still like to add some more facet.missing tests)...
* TestCloudPivotFacet
** randomize overrequest amounts
** randomize facet.mincount usage & assert never exceded
** randomize facet.missing usage & assert that null values are only ever last
in list of values
*** make the odds of docs missing a field more randomized (across test runs)
** add in the possibility of trying to pivot on a field that is in 0 docs
** Dial back some constants to reduce OOM risk when running -Dtests.nightly=true
** example refine count failure from the facet.missing problem (unless there's
another bug that looks really similar) with these changes:
*** {{ant test -Dtestcase=TestCloudPivotFacet -Dtests.method=testDistribSearch
-Dtests.seed=98C12D5256897A09 -Dtests.nightly=true -Dtests.slow=true
-Dtests.locale=sr -Dtests.timezone=America/Louisville
-Dtests.file.encoding=UTF-8}}
* DistributedFacetPivotLongTailTest
** some data tweaks & an additional assertion to ensure refinement is happening
* DistributedFacetPivotSmallTest
** s/honda/null/g - help test that the 4 character string "null" isn't
triggering any special behavior, or getting confused with a missing value in
docs.
* DistributedFacetPivotLargeTest
** comment & assert noting that a shard is left empty (helps with edge case
testing of result merging & refinement)
** added "assertPivot" helper method & did a bit of refactoring
** added test of 2 diff pivots in the same request (swap field order)
** added test of same bi-level pivot with & w/o a tagged fq exclusion in the
same request
** added test variants of facet.limit & facet.index used as localparam
*** currently commented out because it doesn't work -- see SOLR-6193
----
The problem noted above with using {{facet.*}} params as local params in
{{facet.pivot}} is something i discovered earlier this week while writing up
these tests. I initially set the problem set it asside to keep working on
tests, with hte intention of looking into a fix once i had better coverage of
the problem -- but then when i came back to revisit it yesterdan and looked to
the existing {{facet.field}} shard request logic for guidance, i discovered
that didn't seem to work the way i expected either and realized John Gibson
recently filed SOLR-6193 because {{facet.field}} _does_ have the exact same
problem.
i don't think we should let this block adding distributed facet.pivot, let's
tackle it holisticly for all faceting in SOLR-6193.
----
Andrew/Brett: have you guys had a chance to look into the refinement bug when
{{facet.missing}} is used?
(BTW: my update patch only affected test files, so hopefully theres no
collision with anything you guys have been working on -- but if there is, feel
free to just post whatever patch you guys come up with and i'll handle the
merge)
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894_cloud_test.patch, dateToObject.patch,
> pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
