[
https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-4371:
--------------------------------
Attachment: LUCENE-4371.patch
Added missing \@Override
By the way, i noticed something when refactoring the code: slicing/cloning
currently has no safety (except for MMAP). we should think about this for
NIO/Simple too: simple range checks that the slice is in bounds and maybe that
the channel.isOpen. CFSDir could check some of this too, because its "handle"
is now an ordinary input.
But i didn't want to stir up controversy in this refactor (it is unrelated to
this patch). I think there is no performance impact of adding such checks to
NIO/Simple because they already must suffer a buffer refill here anyway. So
maybe we can just open a followup.
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
> Key: LUCENE-4371
> URL: https://issues.apache.org/jira/browse/LUCENE-4371
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch,
> LUCENE-4371.patch, LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in
> all Indexinputs? Just make the slice(...) method return the current
> BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
