[
https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979452#comment-13979452
]
Robert Muir commented on LUCENE-5628:
-------------------------------------
If we want to baby the user, and in not sure what user we have in mind here,
just invoke isfinite. I don't like the code dup nor the precedence that
unrelated code needs to deal with this.
This thing needs to get much shorter and simpler to go in. Can we make it
slower to achieve that? I would make it 10 times slower if it removed 1/2 the
code... Without hesitation.
> SpecialOperations.getFiniteStrings should not recurse
> -----------------------------------------------------
>
> Key: LUCENE-5628
> URL: https://issues.apache.org/jira/browse/LUCENE-5628
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5628.patch
>
>
> Today it consumes one Java stack frame per transition, which when used by
> AnalyzingSuggester is per character in each token. This can lead to stack
> overflows if you have a long suggestion.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
