[
https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979445#comment-13979445
]
Robert Muir commented on LUCENE-5628:
-------------------------------------
Can we reduce the number of lines of code in the new method? It's not even
comparable to the current code. How much of the loc is the cycle detection?
Given the cost, this may not be worth it. This is expert shit and the user can
add assert.isfinite to their code. How much of the loc is code optimization?
Can the old code please be added to automatontestutil as slowxxx and compared
against the new one with random automata?
> SpecialOperations.getFiniteStrings should not recurse
> -----------------------------------------------------
>
> Key: LUCENE-5628
> URL: https://issues.apache.org/jira/browse/LUCENE-5628
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5628.patch
>
>
> Today it consumes one Java stack frame per transition, which when used by
> AnalyzingSuggester is per character in each token. This can lead to stack
> overflows if you have a long suggestion.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
