[
https://issues.apache.org/jira/browse/LUCENE-5622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975265#comment-13975265
]
Dawid Weiss commented on LUCENE-5622:
-------------------------------------
Aside from my previous comment, I don't like the way sysout/ syserr is restored
inside the stream. If you only mean to detect whether anything was printed, you
should delegate writes to original streams, but not restore until the after
method is invoked, much like you already do.
I don't see the point of restoring original streams inside write.
> Fail tests if they print, and tests.verbose is not set
> ------------------------------------------------------
>
> Key: LUCENE-5622
> URL: https://issues.apache.org/jira/browse/LUCENE-5622
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5622.patch
>
>
> Some tests print so much stuff they are now undebuggable (see LUCENE-5612).
> I think its bad that the testrunner hides this stuff, we used to stay on top
> of it. Instead, whne tests.verbose is false, we should install a printstreams
> (system.out/err) that fail the test instantly because they are noisy.
> This will ensure that our tests don't go out of control.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
