[
https://issues.apache.org/jira/browse/SOLR-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967471#comment-13967471
]
Aaron LaBella commented on SOLR-5981:
-------------------------------------
@Shawn, Thanks! That was super fast. The patch looks good to me. And, for
what it's worth, I had actually done a test before posting this issue in the
svn trunk by changing the getSolrWriter method scope to public and it worked
just fine, so, I'm sure changing everything to protected will be equally as
helpful. Thanks again, I think this is a great change to extend the usage of
DataImportHandler. I vote yes to the patch.
> Please change method visibility of getSolrWriter in DataImportHandler to
> public (or at least protected)
> -------------------------------------------------------------------------------------------------------
>
> Key: SOLR-5981
> URL: https://issues.apache.org/jira/browse/SOLR-5981
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Environment: Linux 3.13.9-200.fc20.x86_64
> Solr 4.6.0
> Reporter: Aaron LaBella
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 4.8, 5.0
>
> Attachments: SOLR-5981.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I've been using the org.apache.solr.handler.dataimport.DataImportHandler for
> a bit and it's an excellent model and architecture. I'd like to extend the
> usage of it to plugin my own DIHWriter, but, the code doesn't allow for it.
> Please change ~line 227 in the DataImportHander class to be:
> public SolrWriter getSolrWriter
> instead of:
> private SolrWriter getSolrWriter
> or, at a minimum, protected, so that I can extend DataImportHandler and
> override this method.
> Thank you *sincerely* in advance for the quick turn-around on this. If the
> change can be made in 4.6.0 and upstream, that'd be ideal.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
