[
https://issues.apache.org/jira/browse/SOLR-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967253#comment-13967253
]
Shawn Heisey commented on SOLR-5981:
------------------------------------
Unless someone else has a reason not to, I think we can probably change both of
the private methods to protected. They are only used locally, and if you have
a good use case for extending the class, there's probably no reason we can't
make that possible. If your use case is compelling, perhaps you'd like to
share it?
It is very unlikely you'll see this backported to the 4.6 branch. There's a
slim possibility that it could make it into the 4.7 branch at a later date.
Getting it into 4.8 is the earliest likely version. I need to drive home from
work right now, but when I get there, I may have some time to work on this and
get it into the 4.8 branch, if nobody else jumps on it.
> Please change method visibility of getSolrWriter in DataImportHandler to
> public (or at least protected)
> -------------------------------------------------------------------------------------------------------
>
> Key: SOLR-5981
> URL: https://issues.apache.org/jira/browse/SOLR-5981
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Environment: Linux 3.13.9-200.fc20.x86_64
> Solr 4.6.0
> Reporter: Aaron LaBella
> Priority: Blocker
> Fix For: 4.6
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I've been using the org.apache.solr.handler.dataimport.DataImportHandler for
> a bit and it's an excellent model and architecture. I'd like to extend the
> usage of it to plugin my own DIHWriter, but, the code doesn't allow for it.
> Please change ~line 227 in the DataImportHander class to be:
> public SolrWriter getSolrWriter
> instead of:
> private SolrWriter getSolrWriter
> or, at a minimum, protected, so that I can extend DataImportHandler and
> override this method.
> Thank you *sincerely* in advance for the quick turn-around on this. If the
> change can be made in 4.6.0 and upstream, that'd be ideal.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
