[ 
https://issues.apache.org/jira/browse/LUCENE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935347#action_12935347
 ] 

Grant Ingersoll commented on LUCENE-2691:
-----------------------------------------

I don't have a problem with it, but I don't see how it is any more confusing 
that reopening on a IndexCommit.  In my mind, the thing you are reopening is a 
set of segments.  Unfortunately, we don't have a access in a clean way to get  
the IndexWriter's segment, so we pass in the IW.  The whole point of IR.reopen 
is you are getting a new reader on an index.  Presumably, the IW is on the same 
Directory, just like presumably the CommitPoint is on the same Directory. 

> Consolidate Near Real Time and Reopen API semantics
> ---------------------------------------------------
>
>                 Key: LUCENE-2691
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2691
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2691.patch, LUCENE-2691.patch
>
>
> We should consolidate the IndexWriter.getReader and the IndexReader.reopen 
> semantics, since most people are already using the IR.reopen() method, we 
> should simply add::
> {code}
> IR.reopen(IndexWriter)
> {code}
> Initially, it could just call the IW.getReader(), but it probably should 
> switch to just using package private methods for sharing the internals

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to