[
https://issues.apache.org/jira/browse/LUCENE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920592#action_12920592
]
Earwin Burrfoot commented on LUCENE-2691:
-----------------------------------------
Okay, let's go at it with an example.
{code}
Directory d = Directory.open("/path/to/somewhere"); // Nice
IndexReader r = IndexReader.open(d); // Nice
Directory d2 = new RAMDirectory(); // Okay
IndexWriter w = new IndexWriter(d2); // Sure
r = r.reopen(w) // WTF?!
{code}
Parameterless reopen does not allow you to "rebase" IndexReader, an overload
you introduced with this patch - allows this.
I'm somewhat okay with IR.open(iw). Despite being questionable it is at least
not frikkin' broken like ir.reopen(iw).
> Consolidate Near Real Time and Reopen API semantics
> ---------------------------------------------------
>
> Key: LUCENE-2691
> URL: https://issues.apache.org/jira/browse/LUCENE-2691
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2691.patch, LUCENE-2691.patch
>
>
> We should consolidate the IndexWriter.getReader and the IndexReader.reopen
> semantics, since most people are already using the IR.reopen() method, we
> should simply add::
> {code}
> IR.reopen(IndexWriter)
> {code}
> Initially, it could just call the IW.getReader(), but it probably should
> switch to just using package private methods for sharing the internals
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
