[ 
https://issues.apache.org/jira/browse/LUCENE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949134#comment-13949134
 ] 

Robert Muir commented on LUCENE-5554:
-------------------------------------

-1 to committing anything here right now, and definitely not mikes patch, ever.

Thats just reckless code duplication.

thats also not what mike's benchmark was measuring, and i dont care if 
measuring it does speed that microbenchmark up. 

I am also unsure if the current "performance degradation" is real at all. Its a 
benchmark and the methods in question are compiled with OSR. It seems like it 
may just be a benchmark issue.


> Add TermBulkScorer
> ------------------
>
>                 Key: LUCENE-5554
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5554
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.8, 5.0
>
>         Attachments: LUCENE-5554.patch, LUCENE-5554.patch
>
>
> Hotspot was unhappy with the changes in LUCENE-5487, e.g.: 
> http://people.apache.org/~mikemccand/lucenebench/OrHighHigh.html
> But it looks like we can get the performance back by making a dedicated 
> BulkScorer for TermQuery.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to