[ 
https://issues.apache.org/jira/browse/LUCENE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947357#comment-13947357
 ] 

Robert Muir commented on LUCENE-5554:
-------------------------------------

Well I'm not really sure its specialization. IMO these two methods are 
different things, and should probably be named as such: score() and 
scoreRange() or something. 

They take different parameters and have different return values.

Its just the case (which I did not notice) in LUCENE-5487, that one is changed 
to call the other to try to shoehorn them into one method. Thats why i said, we 
should investigate cleaning this up better: all this patch does is "undo the 
shoehorning".

But we don't need to duplicate term scorer nor change the API if we don't 
really want to.

> Add TermBulkScorer
> ------------------
>
>                 Key: LUCENE-5554
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5554
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.8, 5.0
>
>         Attachments: LUCENE-5554.patch, LUCENE-5554.patch
>
>
> Hotspot was unhappy with the changes in LUCENE-5487, e.g.: 
> http://people.apache.org/~mikemccand/lucenebench/OrHighHigh.html
> But it looks like we can get the performance back by making a dedicated 
> BulkScorer for TermQuery.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to