[ 
https://issues.apache.org/jira/browse/LUCENE-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918794#comment-13918794
 ] 

Michael McCandless commented on LUCENE-5487:
--------------------------------------------

bq. Iirc a BS1 inside a BS1 will work correctly because both use the same doc 
intervals in which the unordered docs can occur.

I think today if you nest two BQs, e.g. all SHOULD clauses, the outer BQ will 
use BS2 and the inner one will use BS1.  This is because BQ's Weight.scorer 
passes "true" for topScorer when it pulls the sub-scorers.

But, the patch should fix this I think, so that BS1 sub-scorer can be used.  So 
the nocommit is to make a test confirming this is really happening... (it's 
hairy!).

> Can we separate "top scorer" from "sub scorer"?
> -----------------------------------------------
>
>                 Key: LUCENE-5487
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5487
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>         Attachments: LUCENE-5487.patch, LUCENE-5487.patch
>
>
> This is just an exploratory patch ... still many nocommits, but I
> think it may be promising.
> I find the two booleans we pass to Weight.scorer confusing, because
> they really only apply to whoever will call score(Collector) (just
> IndexSearcher and BooleanScorer).
> The params are pointless for the vast majority of scorers, because
> very, very few query scorers really need to change how top-scoring is
> done, and those scorers can *only* score top-level (throw throw UOE
> from nextDoc/advance).  It seems like these two types of scorers
> should be separately typed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to