[
https://issues.apache.org/jira/browse/LUCENE-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918680#comment-13918680
]
Uwe Schindler commented on LUCENE-5487:
---------------------------------------
Thanks! The javadocs of TopScorer are outdated. The firstDocId is no longer
passed. I don't like this change, because in the default impl inside
Weight.java, we now need the additional code to check if scorer is still on -1
or not. You added a comment about the setScorer, too. Mabye there is room for
improvements, by:
- documenting API in a better way (sorry the crazyness of this score(Collector,
maxDoc) stuff is horrible to understand, especially, if you want to implement
it correctly!)
- possibly move some code away, so score(Collector) does not need to do the
checks on the underlying sequential scorer
Otherwise, I like the 2 separate classes!
Another idea I had: we can make TopScorer an interface. So Scorers that support
topScoring just need to implement the interface - code looks like before...
Have not thought more about it!
> Can we separate "top scorer" from "sub scorer"?
> -----------------------------------------------
>
> Key: LUCENE-5487
> URL: https://issues.apache.org/jira/browse/LUCENE-5487
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Attachments: LUCENE-5487.patch, LUCENE-5487.patch
>
>
> This is just an exploratory patch ... still many nocommits, but I
> think it may be promising.
> I find the two booleans we pass to Weight.scorer confusing, because
> they really only apply to whoever will call score(Collector) (just
> IndexSearcher and BooleanScorer).
> The params are pointless for the vast majority of scorers, because
> very, very few query scorers really need to change how top-scoring is
> done, and those scorers can *only* score top-level (throw throw UOE
> from nextDoc/advance). It seems like these two types of scorers
> should be separately typed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
