[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885802#comment-13885802
]
Steve Rowe commented on LUCENE-5353:
------------------------------------
bq. I disagree here since a global cleanup is going to take time so I think
progress is better than perfection take the chance and clean it up now.
Okay, in that spirit, I'll add the mile-long ctor, and deprecate all the
setters, including the new {{setFillerToken()}}, and I'll remove the setters
when I commit on trunk.
bq. I am more concerned about the char[] stuff and those should be strings
though.
You said "those", implying multiple char[] stuff, but I think there's only one
- are you thinking of something other than this?:
{code:java}
public static final char[] FILLER_TOKEN = { '_' };
{code}
I'll post a new patch in a minute.
> ShingleFilter should have a way to specify FILLER_TOKEN
> -------------------------------------------------------
>
> Key: LUCENE-5353
> URL: https://issues.apache.org/jira/browse/LUCENE-5353
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.6
> Reporter: Simon Willnauer
> Assignee: Steve Rowe
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5353.patch, LUCENE-5353.patch, LUCENE-5353.patch
>
>
> Today we have no choice that if pos_inc is > 1 there will be a `_` inserted
> in between the tokens. We should have the ability to change this character
> and the char[] that holds it should not be public static since it's mutable.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
