[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885790#comment-13885790
]
Simon Willnauer commented on LUCENE-5353:
-----------------------------------------
bq. I disagree - I don't want to commit a half-assed fix here. I think the way
to go is make another issue to do across-the-board cleanup, on trunk, and
deprecate the existing mess on branch_4x.
I disagree here since a global cleanup is going to take time so I think
progress is better than perfection take the chance and clean it up now. But I
am not going to block it though. I am more concerned about the char[] stuff and
those should be strings though.
> ShingleFilter should have a way to specify FILLER_TOKEN
> -------------------------------------------------------
>
> Key: LUCENE-5353
> URL: https://issues.apache.org/jira/browse/LUCENE-5353
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.6
> Reporter: Simon Willnauer
> Assignee: Steve Rowe
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5353.patch, LUCENE-5353.patch, LUCENE-5353.patch
>
>
> Today we have no choice that if pos_inc is > 1 there will be a `_` inserted
> in between the tokens. We should have the ability to change this character
> and the char[] that holds it should not be public static since it's mutable.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
