[
https://issues.apache.org/jira/browse/LUCENE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914621#action_12914621
]
Michael McCandless commented on LUCENE-2662:
--------------------------------------------
Patch looks good Simon -- some ideas:
* In the class jdocs, I think state that this is basically a
Map<BytesRef,int>?
* Maybe we also move ByteBlockPool --> oal.util?
* Maybe move out the ByteBlockAllocator to its own class (in util)?
RecyclingByteBlockAllocator?
* Can we have DocumentsWriter share the ByteBlockAllocator? (Right
now it's dup'd code since DW also implements this).
* Maybe rename ords -> keys? And hash -> values? (The key isn't
really an "ord" (I think?) because it increases by more than 1
each time... it's more like an address since it references an
address in the byte-pool space).
* We should advertise the limits in the jdocs -- limited to <= 2GB
total byte storage, each key must be <= BLOCK SIZE-2 in length.
* Can we have sortedEntries() not allocate a new iterator object?
Ie, just return the sorted bytesStart int[]? (This is what's done
today, and, for term vectors on small docs, this method is pretty
hot). And the javadocs for this should be stronger -- it's not
that the behaviour is undefined after, it's that you must .clear()
after you're done consume the sorted entries.
> BytesHash
> ---------
>
> Key: LUCENE-2662
> URL: https://issues.apache.org/jira/browse/LUCENE-2662
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: Realtime Branch, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: Realtime Branch, 4.0
>
> Attachments: LUCENE-2662.patch, LUCENE-2662.patch
>
>
> This issue will have the BytesHash separated out from LUCENE-2186
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
