Not breaking binary comparability (so leaving it as it is) is fine. (Shameless plug) Every java main() method deserves http://picocli.info
> On Aug 22, 2017, at 0:32, Gary Gregory <[email protected]> wrote: > > To be clear, what is fine? Leaving it as is, or breaking Core BC and make > the change from "set" to "with" now? > > Gary > >> On Thu, Aug 17, 2017 at 4:21 PM, Remko Popma <[email protected]> wrote: >> >> That's fine I think. >> >> (Shameless plug) Every java main() method deserves http://picocli.info >> >>> On Aug 18, 2017, at 7:18, Gary Gregory <[email protected]> wrote: >>> >>> What I did not do is change the "set" methods to "with" to avoid breaking >>> user sources. We should do that for 3.0 I think. >>> >>> Gary >>> >>>> On Thu, Aug 17, 2017 at 4:10 PM, Remko Popma <[email protected]> >> wrote: >>>> >>>> I like the idiom where setter methods return `this`, so users can chain >>>> methods; thanks for making that change. >>>> >>>> >>>> On Fri, Aug 18, 2017 at 5:41 AM, Gary Gregory <[email protected]> >>>> wrote: >>>> >>>>> Hi All and FYI: >>>>> >>>>> I plan on redoing the SocketOptions class as a real builder by making >> all >>>>> accessors return this. >>>>> >>>>> Any objections? >>>>> >>>>> Gary >>>>> >>>> >>
