dpsenner <[email protected]> wrote on 18.08.2017 12:05:29:
> 
> Github user dpsenner commented on a diff in the pull request:
> 
>     
https://github.com/apache/logging-log4net/pull/15#discussion_r133923978
> 
>     --- Diff: src/Appender/FileAppender.cs ---
>     @@ -695,7 +704,10 @@ public override void ReleaseLock()
>               {
>                  CloseStream(m_stream);
>                  m_stream = null;
>     -         }
>     +
>     +                if (m_appendMutex != null)
>     +                    m_appendMutex.ReleaseMutex();
>     --- End diff --
> 
>     Please wrap this in braces `{` and `}`.

When C#6 (nameof, et. al.) is acceptable, the one-liner 
`m_appendMutex?.ReleaseMutex();` could be even nicer...

Reply via email to