Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924628
--- Diff: src/Appender/FileAppender.cs ---
@@ -620,22 +620,23 @@ public class MinimalLock : LockingModelBase
private string m_filename;
private bool m_append;
private Stream m_stream = null;
-
- /// <summary>
- /// Prepares to open the file when the first message is
logged.
- /// </summary>
- /// <param name="filename">The filename to use</param>
- /// <param name="append">Whether to append to the file,
or overwrite</param>
- /// <param name="encoding">The encoding to use</param>
- /// <remarks>
- /// <para>
- /// Open the file specified and prepare for logging.
- /// No writes will be made until <see
cref="AcquireLock"/> is called.
- /// Must be called before any calls to <see
cref="AcquireLock"/>,
- /// <see cref="ReleaseLock"/> and <see
cref="CloseFile"/>.
- /// </para>
- /// </remarks>
- public override void OpenFile(string filename, bool
append, Encoding encoding)
+ private Mutex m_appendMutex = null;
+ private string m_appendMutexFriendlyName =
"MUTEX_INTERPROCESS_COMMUNICATION_ACROSS_PROCESSES";
--- End diff --
Should this be a more random string?
`MUTEX_INTERPROCESS_COMMUNICATION_ACROSS_PROCESSES` might be in use by anyone.
The mutex name should at least contain `log4net` and a scope what it is used
for. Interprocess communication is not what the mutex locks and thus not the
correct scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
