Hi Magesh,
Thanks for the KIP. It looks good overall.
> default boolean useOverrides() {
> return true;
> }
Is this method really needed? As I understand, nobody should have any
connector client config overrides set right now, since they don't do anything
right now.
For example, you wouldn't expect a Kafka 2.2 installation to have
"producer.override.request.timeout.ms" set, since that doesn't do anything in
Kafka 2.2. So is the option to ignore it in Kafka 2.3 really necessary?
Can you add some details about what happens if a PolicyValidationException is
thrown? I'm assuming that we fail to create the new Connector, I'm not sure if
that's completely spelled out (unless I missed it).
best,
Colin
On Thu, May 9, 2019, at 08:05, Rajini Sivaram wrote:
> Hi Magesh,
>
> Thanks for the KIP, +1 (binding)
>
> Regards,
>
> Rajini
>
>
> On Thu, May 9, 2019 at 3:55 PM Randall Hauch <rha...@gmail.com> wrote:
>
> > Nice work, Magesh.
> >
> > +1 (binding)
> >
> > Randall
> >
> > On Wed, May 8, 2019 at 7:22 PM Magesh Nandakumar <mage...@confluent.io>
> > wrote:
> >
> > > Thanks a lot Chris. So far, the KIP has one non-binding vote and I'm
> > still
> > > looking forward to the KIP to be voted by Friday's deadline.
> > >
> > > On Tue, May 7, 2019 at 10:00 AM Chris Egerton <chr...@confluent.io>
> > wrote:
> > >
> > > > Hi Magesh,
> > > >
> > > > This looks great! Very excited to see these changes finally coming to
> > > > Connect.
> > > > +1 (non-binding)
> > > >
> > > > Cheers,
> > > >
> > > > Chris
> > > >
> > > > On Tue, May 7, 2019 at 9:51 AM Magesh Nandakumar <mage...@confluent.io
> > >
> > > > wrote:
> > > >
> > > > > Hi All,
> > > > >
> > > > > I would like to start a vote on
> > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-458%3A+Connector+Client+Config+Override+Policy
> > > > >
> > > > > The discussion thread can be found here
> > > > > <https://www.mail-archive.com/dev@kafka.apache.org/msg97124.html>.
> > > > >
> > > > > Thanks,
> > > > > Magesh
> > > > >
> > > >
> > >
> >
>
