+1 (nonbinding) from me. Thanks for the KIP, Matthias.
-John On Wed, Jan 16, 2019 at 12:01 PM Guozhang Wang <wangg...@gmail.com> wrote: > Thanks Matthias, I left some minor comments but since they do not involve > in any major architectural changes and I did not feel strong about the > naming etc as well. I'd +1 on the proposal as well. > > Feel free to reply / accept or reject my suggestions on the other DISCUSS > thread. > > > Guozhang > > On Wed, Jan 16, 2019 at 6:38 AM Damian Guy <damian....@gmail.com> wrote: > > > +1 > > > > On Wed, 16 Jan 2019 at 05:09, Patrik Kleindl <pklei...@gmail.com> wrote: > > > > > +1 (non-binding) > > > Thanks too > > > Best regards > > > Patrik > > > > > > > Am 16.01.2019 um 03:30 schrieb Bill Bejeck <bbej...@gmail.com>: > > > > > > > > Thanks for the KIP Matthias. > > > > > > > > +1 > > > > > > > > -Bill > > > > > > > > On Tue, Jan 15, 2019 at 7:33 PM Matthias J. Sax < > matth...@confluent.io > > > > > > > wrote: > > > > > > > >> Hi, > > > >> > > > >> I would like to start the vote for KIP-258: > > > >> > > > >> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB > > > >> > > > >> The KIP adds new stores that allow to store record timestamps next > to > > > >> key and value. Additionally, we will allow to upgrade exiting stores > > to > > > >> the new stores; this will allow us to use the new stores in the DSL > > with > > > >> a smooth upgrade path. > > > >> > > > >> > > > >> -Matthias > > > >> > > > >> > > > > > > > > -- > -- Guozhang >
