Thanks for the updated KIP. +1 (binding)
On Wed, Oct 24, 2018 at 4:52 PM Patrick Huang <hzx...@hotmail.com> wrote: > Hi Jun, > > Sure. I already updated the KIP. Thanks! > > Best, > Zhanxiang (Patrick) Huang > > ________________________________ > From: Jun Rao <j...@confluent.io> > Sent: Wednesday, October 24, 2018 14:17 > To: dev > Subject: Re: [VOTE] KIP-380: Detect outdated control requests and bounced > brokers using broker generation > > Hi, Patrick, > > Could you update the KIP with the changes to ControlledShutdownRequest > based on the discussion thread? > > Thanks, > > Jun > > > On Sun, Oct 21, 2018 at 2:25 PM, Mickael Maison <mickael.mai...@gmail.com> > wrote: > > > +1( non-binding) > > Thanks for the KIP! > > > > On Sun, Oct 21, 2018, 03:31 Harsha Chintalapani <ka...@harsha.io> wrote: > > > > > +1(binding). LGTM. > > > -Harsha > > > On Oct 20, 2018, 4:49 PM -0700, Dong Lin <lindon...@gmail.com>, wrote: > > > > Thanks much for the KIP Patrick. Looks pretty good. > > > > > > > > +1 (binding) > > > > > > > > On Fri, Oct 19, 2018 at 10:17 AM Patrick Huang <hzx...@hotmail.com> > > > wrote: > > > > > > > > > Hi All, > > > > > > > > > > I would like to call for a vote on KIP-380: > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 380%3A+Detect+outdated+control+requests+and+bounced+brokers+using+broker+ > > generation > > > > > > > > > > Here is the discussion thread: > > > > > > > > > > > > > https://lists.apache.org/thread.html/2497114df64993342eaf9c78c0f14b > > f8c1795bc3305f13b03dd39afd@%3Cdev.kafka.apache.org%3E > > > > > KIP-380 > > > > > < > > > https://lists.apache.org/thread.html/2497114df64993342eaf9c78c0f14b > > f8c1795bc3305f13b03dd39afd@%3Cdev.kafka.apache.org%3EKIP-380 > > > >: > > > > > Detect outdated control requests and bounced ...< > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 380%3A+Detect+outdated+control+requests+and+bounced+brokers+using+broker+ > > generation > > > > > > > > > > > Note: Normalizing the schema is a good-to-have optimization because > > the > > > > > memory footprint for the control requests hinders the controller > from > > > > > scaling up if we have many topics with large partition counts. > > > > > cwiki.apache.org > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > Zhanxiang (Patrick) Huang > > > > > > > > > > >