+1( non-binding) Thanks for the KIP! On Sun, Oct 21, 2018, 03:31 Harsha Chintalapani <ka...@harsha.io> wrote:
> +1(binding). LGTM. > -Harsha > On Oct 20, 2018, 4:49 PM -0700, Dong Lin <lindon...@gmail.com>, wrote: > > Thanks much for the KIP Patrick. Looks pretty good. > > > > +1 (binding) > > > > On Fri, Oct 19, 2018 at 10:17 AM Patrick Huang <hzx...@hotmail.com> > wrote: > > > > > Hi All, > > > > > > I would like to call for a vote on KIP-380: > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-380%3A+Detect+outdated+control+requests+and+bounced+brokers+using+broker+generation > > > > > > Here is the discussion thread: > > > > > > > https://lists.apache.org/thread.html/2497114df64993342eaf9c78c0f14bf8c1795bc3305f13b03dd39afd@%3Cdev.kafka.apache.org%3E > > > KIP-380 > > > < > https://lists.apache.org/thread.html/2497114df64993342eaf9c78c0f14bf8c1795bc3305f13b03dd39afd@%3Cdev.kafka.apache.org%3EKIP-380 > >: > > > Detect outdated control requests and bounced ...< > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-380%3A+Detect+outdated+control+requests+and+bounced+brokers+using+broker+generation > > > > > > > Note: Normalizing the schema is a good-to-have optimization because the > > > memory footprint for the control requests hinders the controller from > > > scaling up if we have many topics with large partition counts. > > > cwiki.apache.org > > > > > > > > > > > > Thanks, > > > Zhanxiang (Patrick) Huang > > > >