hi Yishun Thanks for nice KIP!
Q1) Why VerifiableProducer extend Closeable rather than AutoCloseable? Q2) I grep project and then noticed there are other close methods but do not implement AutoCloseable. For example: 1) WorkerConnector 2) MemoryRecordsBuilder 3) MetricsReporter 4) ExpiringCredentialRefreshingLogin 5) KafkaChannel 6) ConsumerInterceptor 7) SelectorMetrics 8) HeartbeatThread Cheers, Chia-Ping On 2018/09/26 23:44:31, Yishun Guan <gyis...@gmail.com> wrote: > Hi All, > > Here is a trivial KIP: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=93325308 > > Suggestions are welcome. > > Thanks, > Yishun >
