Hi Bill, I see, i just updated the KIP with all the changes. And your second concern make sense - if that's what everyone think, we can start with changing KafkaStream first.
Thanks, Yishun On Wed, Sep 26, 2018 at 5:18 PM Bill Bejeck <bbej...@gmail.com> wrote: > > Hi Yishun, > > Thanks for the KIP, seems like a useful addition. > > Just a couple of minor comments. > > Can you list all the changes in the list under "Public Interfaces" in the > "Proposed Changes" section that way it's clear what's changing? I realize > they all will be very similar, but it's better to be explicit with the > proposed changes in a KIP > > Also, you are proposing changes across several components and I'm not sure > if that is possible in a single KIP, but I could very well be wrong on this > one, so we'll see what others say. > > Thanks, > Bill > > On Wed, Sep 26, 2018 at 7:44 PM Yishun Guan <gyis...@gmail.com> wrote: > > > Hi All, > > > > Here is a trivial KIP: > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=93325308 > > > > Suggestions are welcome. > > > > Thanks, > > Yishun > >