Hi, thank you Ted! I have addressed your comments:

1. Added more descriptions about later optimization.
2. Yes, I will implement the V3 later when this KIP gets accepted.
3. Fixed.

Thanks,
Yishun

On Fri, Aug 10, 2018 at 3:32 PM Ted Yu <yuzhih...@gmail.com> wrote:

> bq. this is the foundation of some later possible optimizations(enable
> batching in *describeConsumerGroups ...*
>
> *Can you say more why this change lays the foundation for the future
> optimizations ?*
>
> *You mentioned **FIND_COORDINATOR_REQUEST_V3 in the wiki but I don't see it
> in PR.*
> *I assume you would add that later.*
>
> *Please read your wiki and fix grammatical error such as the following:*
>
> bq. that need to be make
>
> Thanks
>
> On Wed, Aug 8, 2018 at 3:55 PM Yishun Guan <gyis...@gmail.com> wrote:
>
> > Hi all,
> >
> > I would like to start a discussion on:
> >
> > KIP-347: Enable batching in FindCoordinatorRequest
> > https://cwiki.apache.org/confluence/x/CgZPBQ
> >
> > Thanks @Guozhang Wang <wangg...@gmail.com> for his help and patience!
> >
> > Thanks,
> > Yishun
> >
>

Reply via email to