Thanks for the KIP, Stanislav. The following PR looks related: https://github.com/apache/kafka/pull/4093/files
Ismael On Thu, Jul 5, 2018 at 8:44 AM Stanislav Kozlovski <stanis...@confluent.io> wrote: > Hey everybody, > > I just created a new KIP about exposing more information in exceptions > caused by consumer record deserialization/validation. Please have a look at > it, it is a very short page. > > I am working under the assumption that all invalid record or > deserialization exceptions in the consumer pass through the `Fetcher` > class. Please confirm if that is true, otherwise I might miss some places > where the exceptions are raised in my implementation > > One concern I have is the name of the second exception - > `InoperativeRecordException`. I would have named it > `InvalidRecordException` but that is taken. The `Fetcher` class catches > `InvalidRecordException` (here > < > https://github.com/apache/kafka/blob/c5b00d20d3703b7fc4358b7258d5d6adb890136f/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java#L1081 > > > and here > < > https://github.com/apache/kafka/blob/c5b00d20d3703b7fc4358b7258d5d6adb890136f/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java#L1092 > >) > and re-raises it as `KafkaException`, which exposes it as a non-retriable > exception to the user (`InvalidRecordException` extends > `RetriableExecption`, but `KafkaException` doesn't). > A suggestion I got for an alternative name was > `InvalidFetchRecordException`. Please chime in if you have ideas > > Confluence page: KIP-334 > <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87297793 > > > JIRA Issue: KAFKA-5682 <https://issues.apache.org/jira/browse/KAFKA-5682> > -- > Best, > Stanislav >
