Hmm, do we still need one more binding +1, or did I misread the vote thread?
+1 (non-binding) from me. As I posted in the other thread, I think it would make sense to name the new ZK hierarchy /kafka-prefix-acls or similar, to reflect the fact that they are ACLs that match by a name prefix. They're not really "wildcards" It would also be nice to have a MatchType enum in the Resource class like LITERAL (for existing ACLs) and PREFIX (for the new ACL type). This would put us in a good position to implement new ACL types in the future if the desire arises, and also clearly explain how each type works. best, Colin On Mon, May 21, 2018, at 13:40, Piyush Vijay wrote: > Thanks for the +1s. I'll send out a PR shortly. > > Thanks > > > Piyush Vijay > > On Mon, May 21, 2018 at 8:59 AM, Guozhang Wang <wangg...@gmail.com> wrote: > > > Thanks for the KIP, +1 from me (binding). > > > > > > Guozhang > > > > On Mon, May 21, 2018 at 5:22 AM, Damian Guy <damian....@gmail.com> wrote: > > > > > +1 (binding) > > > > > > On Sat, 19 May 2018 at 03:51 Piyush Vijay <piyushvij...@gmail.com> > > wrote: > > > > > > > Hi everyone, > > > > > > > > I would like to start a vote for > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 290%3A+Support+for+wildcard+suffixed+ACLs > > > > . > > > > > > > > The KIP proposes a way to support wildcard-suffixed resource names in > > > Kafka > > > > ACLs. > > > > > > > > The main challenge was to support it in a backward compatible way > > because > > > > resources like consumer groups don't have defined naming convention and > > > can > > > > have '*' in their names. > > > > > > > > Please take a look. > > > > > > > > Thanks > > > > > > > > Piyush Vijay > > > > > > > > > > > > > > > -- > > -- Guozhang > >
