Hi Piyush. I think it would be better to match the flag in kafka-acls.sh to the new enum. Instead of stating “–wildcard-suffixed-resource true” I think “–resource-type wildcard” is much better because it allows support for new enum constants that might be added in the future via the same flag.
Also, a minor point, in the Compatibility, Deprecation, and Migration section, I think what happens on downgrade is the wildcard suffixed ACLs are ignored because the old code doesn’t know to look in the separate Zookeeper area. I bet getting this done by the end of the day was stressful :-). Nice job, though. Ron > On May 18, 2018, at 11:47 PM, Piyush Vijay <piyushvij...@gmail.com> wrote: > > https://cwiki.apache.org/ > confluence/display/KAFKA/KIP-290%3A+Support+for+wildcard+suffixed+ACLs