While working on implementing this KIP (already approved) I now realize 
that the proposed protocol requires a small change.

Since the protocol allows for deleting multiple groups at the same time, 
returning a high level error code does not really make sense, and can not 
normally be generalized to all groups. Therefore, it may very well be the 
case that a Errors.COORDINATOR_NOT_AVAILABLE error would apply to some 
groups (groups to be deleted may belong to different coordinators), 
Errors.GROUP_AUTHORIZATION_FAILED would apply to some other, etc.

So the response protocol would change from

DeleteGroups Response (Version: 0) => throttle_time_ms error_code 
[group_error_codes]
  throttle_time_ms => INT32
  error_code => INT16
  group_error_codes => group error_code
    group_id => STRING
    error_code => INT16

to

DeleteGroups Response (Version: 0) => throttle_time_ms [group_responses]
  throttle_time_ms => INT32
  group_responses => group_id error_code
    group_id => STRING
    error_code => INT16

I will update the KIP with this small change, and am hoping a revote is 
not required.
If there are any feedback or objections please let me know.

Thanks.
--Vahid




From:   "Vahid S Hashemian" <vahidhashem...@us.ibm.com>
To:     dev@kafka.apache.org
Date:   01/12/2018 10:30 AM
Subject:        Re: [DISCUSS] KIP-229: DeleteGroups API



If there are no additional comments/feedback on this KIP, I'll start a 
vote on Monday.

Thanks.
--Vahid




From:   "Vahid S Hashemian" <vahidhashem...@us.ibm.com>
To:     dev <dev@kafka.apache.org>
Date:   11/28/2017 04:03 PM
Subject:        [DISCUSS] KIP-229: DeleteGroups API



Hi everyone,

I started KIP-229 and proposed a consumer group deletion API for 
Kafka-based group management to address KAFKA-6275: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_KAFKA_KIP-2D229-253A-2BDeleteGroups-2BAPI&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-kjJc7uSVcviKUc&m=lCHMtLmnt5dkgkLO9QCnRE35mTcVQFeA9GNAPluRG0M&s=9YR-1Ba2XLn8ewS3ZpPH4PzdfOIel39HhdEk8oojrXI&e=


Your feedback and suggestions are welcome!

Thanks.
--Vahid










Reply via email to