Hi Vahid, Seems reasonable to me. A few questions.
1. What error code do we use when the group is not empty? 2. Do we need the capability to delete offsets individually for a partition? I ask because the offset tool lets you set the offset for partitions individually, so it might be natural to expect you could also delete them individually. We could leave this as potential future work if the use case is not too compelling. 3. Looks like you've added this API to the internal AdminClient. Wanted to check if that was intentional. Since the public AdminClient doesn't support any of the group admin capabilities, I think it's reasonable to leave it out of this KIP. Thanks, Jason On Mon, Dec 11, 2017 at 2:19 PM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > If there are no additional feedback on this KIP, I'll start a vote in a > couple of days. > > Thanks. > --Vahid > > > > From: Vahid S Hashemian/Silicon Valley/IBM > To: dev@kafka.apache.org > Date: 11/29/2017 11:15 AM > Subject: Re: [DISCUSS] KIP-229: DeleteGroups API > > > Hi Dong, > > Thanks a lot for your feedback. > I updated the KIP and included those fields and also made a note of the > corresponding AdminClient API that will be created to support deleting > consumer groups. > I hope the updates address your suggestions. > > Cheers! > > --Vahid > > > > > > From: Dong Lin <lindon...@gmail.com> > To: dev@kafka.apache.org > Date: 11/28/2017 11:16 PM > Subject: Re: [DISCUSS] KIP-229: DeleteGroups API > > > > Hey Vahid, > > Thanks for the KIP! This is certainly a useful one and users have been > asking about the ability to delete group from the Kafka offset topic in my > past experience. > > It seems that the protocol of the new request/response should probably > include more fields fields. For example, it may be useful to include > throttle_time_ms field and a request level error code in > DeleteGroupsResponse. The request level error code can possibly show error > such as NOT_COORDINATOR_FOR_GROUP. > > Also, user may want to use this feature programmatically. Do you think we > should add a corresponding API in AminClient to delete groups? If so, can > you specify the new AdminClient API in the KIP? > > Thanks, > Dong > > > On Tue, Nov 28, 2017 at 4:03 PM, Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > Hi everyone, > > > > I started KIP-229 and proposed a consumer group deletion API for > > Kafka-based group management to address KAFKA-6275: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki. > apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_ > iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj- > kjJc7uSVcviKUc&m=97ut7r-oek0jZuRXs-VmWvs_86JChFctd2xFoP4Y2tI&s=ZT_ > XH0rdqPD82T3oMqwcsAi19zCXhq9Zkh9bfffSYLk&e= > > > 229%3A+DeleteGroups+API > > Your feedback and suggestions are welcome! > > > > Thanks. > > --Vahid > > > > > > > > > > > >
