Hi, Rajini, Thank for the KIP. +1. Just a couple of minor comments below.
50. config.secret.*: Could you document how the encryption/decryption of passwd work? In particular, how do we support changing config.secret? 51. At the topic level, we also have leader.replication.throttled.replicas and follower.replication.throttled.replicas. Should they be dynamically configurable? Jun On Tue, Dec 12, 2017 at 9:24 AM, Gwen Shapira <g...@confluent.io> wrote: > +1 (binding). Thank you for leading this, Rajini. > > On Tue, Dec 12, 2017 at 8:35 AM Tom Bentley <t.j.bent...@gmail.com> wrote: > > > +1 (nonbinding) > > > > On 12 December 2017 at 15:34, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > +1 > > > > > > On Tue, Dec 12, 2017 at 5:44 AM, Rajini Sivaram < > rajinisiva...@gmail.com > > > > > > wrote: > > > > > > > Since there are no more outstanding comments, I would like to start > > vote > > > > for KIP-226: > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > 226+-+Dynamic+Broker+Configuration > > > > > > > > > > > > The KIP enables dynamic update of commonly updated broker > configuration > > > > options to avoid expensive restarts. > > > > > > > > Thank you, > > > > > > > > Rajini > > > > > > > > > >
