Hi all, Would we safely accept this KIP since three binding votes have already been collected (from Jun, Guozhang and Becket)?
________________________________ 发件人: Guozhang Wang <wangg...@gmail.com> 发送时间: 2017年12月6日 22:40 收件人: dev@kafka.apache.org 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hi Hu Xi, As I said before, it is only a clarification question for its internal implementation; it is not related to the public interfaces. Guozhang On Wed, Dec 6, 2017 at 12:34 AM, Hu Xi <huxi...@hotmail.com> wrote: > Hi Guozhang, > > > Correct me if I am wrong. Of course I could construct the sensor where > per-partition metrics reside as a child of the client-level > "records-lead-min", but it seems that whether doing that way takes no > effects on what this KIP gonna do, so is it a must? > > ________________________________ > 发件人: Guozhang Wang <wangg...@gmail.com> > 发送时间: 2017年12月6日 15:05 > 收件人: dev@kafka.apache.org > 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead > metrics to KafkaConsumer > > Hello Xi, > > You can see that in o.a.k.common.metrics.Sensor, we allow constructors to > pass in one or more "parent" Sensors of the constructed Sensor, behind the > scene when a child sensor's metrics have been updated, the updates will be > propagated all the way up to its parents and ancestors (you can checkout > the source code for its impl). On different clients we have been using this > to build many hierarchical sensors, like per-dest-broker metrics v.s. > all-dest-broker metrics on selector, etc. > > My understanding is that the cross-all-partitions "records-lead-min" will > be constructed as the parent of all the per-partition "records-lead-min", > is that true? > > > Guozhang > > On Mon, Dec 4, 2017 at 11:26 PM, Hu Xi <huxi...@hotmail.com> wrote: > > > Guozhang, > > > > > > Thanks for the vote and comments. I am not sure if I fully understand the > > parent metrics here. This KIP will introduce a client-level metric named > > 'records-lead-min' and three per-partition metrics tagged with > > topic&partition. Is it the child-parent relationship you mean? > > > > > > ________________________________ > > 发件人: Guozhang Wang <wangg...@gmail.com> > > 发送时间: 2017年12月5日 15:16 > > 收件人: dev@kafka.apache.org > > 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead > > metrics to KafkaConsumer > > > > Thanks Hu Xi, > > > > I made a pass over the KIP and it lgtm. +1. > > > > Just a clarification question: for the cross-partition "records-lead-min" > > metric, would that be implemented as a parent metric of the per-partition > > metrics? > > > > > > Guozhang > > > > > > On Mon, Dec 4, 2017 at 3:07 PM, Dong Lin <lindon...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > On Wed, Nov 29, 2017 at 7:05 PM, Hu Xi <huxi...@hotmail.com> wrote: > > > > > > > Hi all, > > > > > > > > As I didn't see any further discussion around this KIP, I'd like to > > start > > > > voting. > > > > > > > > KIP documentation: > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > 223+-+Add+per-topic+min+lead+and+per-partition+lead+ > > > > metrics+to+KafkaConsumer > > > > > > > > > > > > > > > > Cheers, > > > > > > > > huxihx > > > > > > > > > > > > > > > -- > > -- Guozhang > > > > > > -- > -- Guozhang > -- -- Guozhang
