Thanks Hu Xi, I made a pass over the KIP and it lgtm. +1.
Just a clarification question: for the cross-partition "records-lead-min" metric, would that be implemented as a parent metric of the per-partition metrics? Guozhang On Mon, Dec 4, 2017 at 3:07 PM, Dong Lin <lindon...@gmail.com> wrote: > +1 (non-binding) > > On Wed, Nov 29, 2017 at 7:05 PM, Hu Xi <huxi...@hotmail.com> wrote: > > > Hi all, > > > > As I didn't see any further discussion around this KIP, I'd like to start > > voting. > > > > KIP documentation: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 223+-+Add+per-topic+min+lead+and+per-partition+lead+ > > metrics+to+KafkaConsumer > > > > > > > > Cheers, > > > > huxihx > > > -- -- Guozhang
