Hi,
Thanks for your comments. @Ted API is given without much javadoc on the role / meaning of method > parameters. - I thought they are self-explanatory but I will add some more comments in the document. @Matthias - how does this relate to `KStream#through()` ? - The main difference between `KStream#through()` and this KIP is that the repartition topic should be created manually (when using `KStream#through()`). However, it is better if we can handle some part of manual work transparent to the user. I thought to add this functionality to `Produced`. However, there was some conceptual issues. In all `KStream#through()` method overloads, we state that topics should be created manually. If we overload another `KStream#through()` method (say, with different parameters) saying the topic name/partitions is up to the user, this might seem weird. Either we can enlarge the scope of `KStream#through()` or we create new overloads and keep both (`KStream#through()` and RepartitionHint) of them. Cheers, Jeyhun On Sat, Nov 4, 2017 at 7:22 PM Ted Yu <yuzhih...@gmail.com> wrote: > w.r.t. KIP-182, KAFKA-5651 has been resolved. > But the KIP is still labeled Under Discussion. > > Should KIP-182 be moved to Adopted state ? > > On Sat, Nov 4, 2017 at 10:06 AM, Matthias J. Sax <matth...@confluent.io> > wrote: > > > Thanks for the KIP. > > > > Two comments/questions: > > > > - how does this relate to `KStream#through()` ? > > - do we really need to add new overload or can we just extends exiting > > options (cf KIP-182); it would be create if we could just extend > > existing classes like `Produced` instead of adding new methods to "main" > > classes > > > > Maybe, we could use `through()` to create a topics in the back ground > > and picky back all to `Produced`. > > > > > > -Matthias > > > > On 11/4/17 4:16 PM, Ted Yu wrote: > > > API is given without much javadoc on the role / meaning of method > > > parameters. > > > > > > Can you enrich with descriptive javadoc ? > > > > > > On Sat, Nov 4, 2017 at 8:01 AM, Jeyhun Karimov <je.kari...@gmail.com> > > wrote: > > > > > >> Dear community, > > >> > > >> I would like to initiate discussion on KIP-221 [1] based on issue [2]. > > >> Please feel free to comment. > > >> > > >> [1] > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >> 221%3A+Repartition+Topic+Hints+in+Streams > > >> [2] https://issues.apache.org/jira/browse/KAFKA-6037 > > >> > > >> > > >> > > >> Cheers, > > >> Jeyhun > > >> > > > > > > > >
