Thanks Ismael. Yes, you're right, PR 3799 is purely a refactoring. There are new subtasks of https://issues.apache.org/jira/browse/KAFKA-3480 <https://issues.apache.org/jira/browse/KAFKA-3480> that I haven't yet filed, that I want to work on. They will add auto generation of metrics documentation for more areas of the codebase. So I was trying to figure out what were my chances of getting them into 1.0.0, to help me prioritize when I should work on them.
But to your general point, it sounds like if I make my case and the community agrees that its worth the cost/benefit, that it might be eligible to get into 1.0.0. Sounds perfect. Thanks! -James > On Sep 20, 2017, at 3:14 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > Hi James, > > Isn't PR 3799 purely a code refactoring (i.e. no change in behaviour)? If > so, it would probably land in trunk only after today. If it's new > functionality, then it depends on size, risk and importance. If you think > it's important and should target 1.0.0, feel free to make your case in the > JIRA or PR. > > Thanks, > Ismael > > On Wed, Sep 20, 2017 at 10:59 PM, James Cheng <wushuja...@gmail.com> wrote: > >> Hi. I'm a little unclear on what types of things are subject to the >> "Feature Freeze" today (Sept 20th). >> >> For changes such as https://github.com/apache/kafka/pull/3799 < >> https://github.com/apache/kafka/pull/3799> and https://issues.apache.org/ >> jira/browse/KAFKA-3480 <https://issues.apache.org/jira/browse/KAFKA-3480> >> that don't require KIPs, is today the freeze date? If I have PR created but >> not yet reviewed, does that mean it is eligible to get into 1.0.0? >> >> And if I have a PR that comes AFTER today, does that mean it is NOT >> eligible for 1.0.0? >> >> Thanks! >> >> -James >> >>> On Sep 11, 2017, at 12:14 PM, Guozhang Wang <wangg...@gmail.com> wrote: >>> >>> Sure! Please feel free to update the wiki. >>> >>> >>> Guozhang >>> >>> On Mon, Sep 11, 2017 at 9:28 AM, Rajini Sivaram <rajinisiva...@gmail.com >>> >>> wrote: >>> >>>> Hi Guozhang, >>>> >>>> Can KIP-188 be added to the list, please? The vote has passed and PR >> should >>>> be ready soon. >>>> >>>> Thank you, >>>> >>>> Rajini >>>> >>>> On Thu, Sep 7, 2017 at 10:28 PM, Guozhang Wang <wangg...@gmail.com> >> wrote: >>>> >>>>> Actually my bad, there is already a voting thread and you asked people >> to >>>>> recast a vote on a small change. >>>>> >>>>> On Thu, Sep 7, 2017 at 2:27 PM, Guozhang Wang <wangg...@gmail.com> >>>> wrote: >>>>> >>>>>> Hi Tom, >>>>>> >>>>>> It seems KIP-183 is still in the discussion phase, and voting has not >>>>> been >>>>>> started? >>>>>> >>>>>> >>>>>> Guozhang >>>>>> >>>>>> >>>>>> On Thu, Sep 7, 2017 at 1:13 AM, Tom Bentley <t.j.bent...@gmail.com> >>>>> wrote: >>>>>> >>>>>>> Would it be possible to add KIP-183 to the list too, please? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Tom >>>>>>> >>>>>>> On 6 September 2017 at 22:04, Guozhang Wang <wangg...@gmail.com> >>>> wrote: >>>>>>> >>>>>>>> Hi Vahid, >>>>>>>> >>>>>>>> Yes I have just added it while sending this email :) >>>>>>>> >>>>>>>> >>>>>>>> Guozhang >>>>>>>> >>>>>>>> On Wed, Sep 6, 2017 at 1:54 PM, Vahid S Hashemian < >>>>>>>> vahidhashem...@us.ibm.com >>>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Guozhang, >>>>>>>>> >>>>>>>>> Thanks for the heads-up. >>>>>>>>> >>>>>>>>> Can KIP-163 be added to the list? >>>>>>>>> The proposal for this KIP is accepted, and the PR is ready for >>>>> review. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> --Vahid >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> From: Guozhang Wang <wangg...@gmail.com> >>>>>>>>> To: "dev@kafka.apache.org" <dev@kafka.apache.org> >>>>>>>>> Date: 09/06/2017 01:45 PM >>>>>>>>> Subject: 1.0.0 KIPs Update >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Hello folks, >>>>>>>>> >>>>>>>>> This is a heads up on 1.0.0 progress: >>>>>>>>> >>>>>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.a >>>>>>>>> pache.org_confluence_pages_viewpage.action-3FpageId-3D717649 >>>>>>>>> 13&d=DwIBaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_ >>>>>>>>> xUKl7Nzswo6KE4Nj-kjJc7uSVcviKUc&m=bLvgeykOujjty9joOuWXD4wZab >>>>>>>>> o1CV0pULY4eqBxqzk&s=90UN7ejzCQmdPOyRR_ >>>> 2z304xLUSBCtOYi0KqhAo4EyU&e= >>>>>>>>> >>>>>>>>> >>>>>>>>> We have one week left towards the KIP deadline, which is Sept. >>>> 13th. >>>>>>>> There >>>>>>>>> are still a lot of KIPs that under discussion / voting process. >>>> For >>>>>>> the >>>>>>>>> KIP >>>>>>>>> proposer, please keep in mind that the voting has to be done >>>> before >>>>>>> the >>>>>>>>> deadline in order to be added into the coming release. >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> -- Guozhang >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> -- Guozhang >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- Guozhang >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -- Guozhang >>>>> >>>> >>> >>> >>> >>> -- >>> -- Guozhang >> >>
