+1. Thanks for the KIP, Sumant and Joel. On Fri, Sep 8, 2017 at 11:33 AM, Jason Gustafson <ja...@confluent.io> wrote:
> +1. Thanks for the KIP. > > On Fri, Sep 8, 2017 at 8:17 AM, Sumant Tambe <suta...@gmail.com> wrote: > > > Updated. > > > > On 8 September 2017 at 02:04, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > Thanks for the KIP. +1 (binding) from me. Just a minor suggestion, I > > would > > > mention the following under "Public Interfaces": > > > > > > Default value of delivery.timeout.ms = 120 seconds > > > Default value of retries will be changed to MAX_INT > > > request.timeout.ms – current meaning, but messages are not expired > after > > > this time. I.e., request.timeout.ms is no longer relevant for batch > > > expiry. > > > > > > The compatibility impact of such changes can remain in the > compatibility > > > section. Also, I agree about keeping your "reordering" text although it > > > seems like the wiki wasn't updated to match what you posted in the > > > discussion thread. > > > > > > Ismael > > > > > > On Fri, Sep 8, 2017 at 6:06 AM, Sumant Tambe <suta...@gmail.com> > wrote: > > > > > > > Hi all, > > > > > > > > I would like to open the vote for KIP-91: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-91+ > > > > Provide+Intuitive+User+Timeouts+in+The+Producer > > > > > > > > Thank you all for your input on the kip so far. > > > > > > > > Regards, > > > > Sumant > > > > > > > > > >
