Yes, you are right. It is worth mentioning since the default value of the retries config is changing.
Thanks, Apurva On Thu, Sep 7, 2017 at 10:25 PM, Sumant Tambe <suta...@gmail.com> wrote: > I added the following: Due to change in the default value of retries from 0 > to MAX_INT and the existing default value of > max.in.flight.request.per.connection==5, reordering becomes a possibility > by default. To prevent reordering, set > max.in.flight.request.per.connection==1. > > It does not hurt to mention it as it's a default behavior change? > > On 7 September 2017 at 22:15, Apurva Mehta <apu...@confluent.io> wrote: > > > Thanks for the KIP Sumant, +1 from me. > > > > That is the most exhaustive 'Rejected Alternatives' section that I have > > seen :) > > > > One minor point: In the compatibility section, your note on > > 'max.in.flight.requests.per.connection == 5' resulting in out of order > > delivery is true irrespective of these changes. As such, I don't think it > > should be mentioned in the context of this KIP. > > > > Thanks, > > Apurva > > > > On Thu, Sep 7, 2017 at 10:06 PM, Sumant Tambe <suta...@gmail.com> wrote: > > > > > Hi all, > > > > > > I would like to open the vote for KIP-91: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 91+Provide+Intuitive+User+Timeouts+in+The+Producer > > > > > > Thank you all for your input on the kip so far. > > > > > > Regards, > > > Sumant > > > > > >
