Hi, Raijini, Thanks for the KIP. +1. Just a minor comment.
Since we only measure MessageConversionsTimeMs at the request type level, is it useful to collect the following metrics at the topic level? *MBean*: kafka.server:type=BrokerTopicMetrics,name=FetchMessageConversionsPerSec,topic=([-.\w]+) *MBean*: kafka.server:type=BrokerTopicMetrics,name=ProduceMessageConversionsPerSec,topic=([-.\w]+) Also, for the ZK latency metric, Onur added a new ZookeeperClient wrapper and is in the middle of converting existing zkClient usage to the new wrapper. So, we probably want to add the latency metric in the new wrapper. Jun On Thu, Aug 24, 2017 at 10:50 AM, Rajini Sivaram <rajinisiva...@gmail.com> wrote: > Hi all, > > I would like to start the vote on KIP-188 that adds additional metrics to > support health checks for Kafka Ops. Details are here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 188+-+Add+new+metrics+to+support+health+checks > > Thank you, > > Rajini >
