Thanks for the KIP Eno! Couple of comments:
I think we don't need `RecordContext` in `RecordExceptionHandler#handle` because the `ConsumerRecord` provides all this information anyway. Why we introduce `ExceptionType` and not just hand in the actual exception? As return type of `handle()` is void, how would the handler fail? By throwing an exception? Maybe it would be better to add a proper return type from the beginning on -- this might also make backward compatibility easier later on. Question about `LogAndThresholdExceptionHandler` -- how would we be able to track this? With regard to `DeserializationException`, do you thing it might make sense to have a "dead letter queue" as a feature to provide out-of-the-box? -Matthias On 5/25/17 2:47 AM, Eno Thereska wrote: > Hi there, > > I’ve added a KIP on improving exception handling in streams: > KIP-161: streams record processing exception handlers. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-161%3A+streams+record+processing+exception+handlers > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-161:+streams+record+processing+exception+handlers> > > Discussion and feedback is welcome, thank you. > Eno >
signature.asc
Description: OpenPGP digital signature
