Hi Matthias, For the AdminClient, client configuration is needed. And for zookeeper, no properties are required. So, in other tools like consumerGroupCommand, they used the command config option. I think consumer-config and consumer-property are not required here. We will use the configurations passed through command-config for both admin client and Embedded consumer.
Thanks, Bharat On Fri, May 19, 2017 at 4:26 PM, Matthias J. Sax <matth...@confluent.io> wrote: > Couple of follow ups. > > The reset tool uses AdminClient, ZkUtils, and a KafkaConsumer > internally. Thus, I am wondering if we need the possibility to specify > configs for all of them? > > The original JIRA reported, that the reset tool does not work for a > secured cluster, and thus, I doubt that consumer properties are > sufficient for resolve this. > > Maybe some people that are more familiar with Kafka security can help > out here. I personally have only limited knowledge about this topic. > > > -Matthias > > > > On 5/19/17 11:09 AM, BigData dev wrote: > > Thanks for the info, Matthias. > > > > Regards, > > Bharat > > > > > > On Fri, May 19, 2017 at 10:25 AM, Matthias J. Sax <matth...@confluent.io > > > > wrote: > > > >> KIP-157 cannot be included in 0.11.0.0 anymore. KIP freeze date deadline > >> is strict. > >> > >> -Matthias > >> > >> On 5/19/17 10:15 AM, BigData dev wrote: > >>> Hi Matthias, > >>> I will start a new KIP for Kafka tools options to be a standard across > >> all > >>> tools shortly. But I think the KIP 157 for Kafka Streams, should be > >> needed > >>> for 0.11.0.0 release, (KIP freeze date is already over, but I think > this > >> is > >>> minor code change in tools to add option to streams reset tool) as > >> without > >>> this consumer config options, it will not be possible to use the tool > in > >> a > >>> secured environment. Please let me know your thoughts on this. If it > >> needs > >>> to be moved to next release, I will work on this as part of KIP 14. > >>> > >>> Thanks, > >>> Bharat > >>> > >>> > >>> On Fri, May 19, 2017 at 10:10 AM, Matthias J. Sax < > matth...@confluent.io > >>> > >>> wrote: > >>> > >>>> I double checked with Matthew Warhaftig (the original author of > KIP-14) > >>>> and he has not interest to continue the KIP atm. > >>>> > >>>> Thus, Bharat can continue the work on KIP-14. I think it would be > best, > >>>> to start a new DISCUSS thread after you update KIP-14. > >>>> > >>>> Thanks for your contributions! > >>>> > >>>> > >>>> -Matthias > >>>> > >>>> > >>>> On 5/17/17 12:56 PM, BigData dev wrote: > >>>>> Hi, > >>>>> When I was trying to find more info, there is already a proposed KIP > >> for > >>>>> this > >>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >>>> 14+-+Tools+Standardization > >>>>> > >>>>> > >>>>> Thanks, > >>>>> Bharat > >>>>> > >>>>> On Wed, May 17, 2017 at 12:38 PM, BigData dev < > bigdatadev...@gmail.com > >>> > >>>>> wrote: > >>>>> > >>>>>> Hi Ewen, Matthias, > >>>>>> For common configuration across all the tools, I will work on that > as > >>>> part > >>>>>> of other KIP by looking into all Kafka tools. > >>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Bharat > >>>>>> > >>>>>> > >>>>>> On Wed, May 17, 2017 at 9:40 AM, Matthias J. Sax < > >> matth...@confluent.io > >>>>> > >>>>>> wrote: > >>>>>> > >>>>>>> +1 > >>>>>>> > >>>>>>> I also second Ewen comment -- standardizing the common supported > >>>>>>> parameters over all tools would be great! > >>>>>>> > >>>>>>> > >>>>>>> -Matthias > >>>>>>> > >>>>>>> On 5/17/17 12:57 AM, Damian Guy wrote: > >>>>>>>> +1 > >>>>>>>> > >>>>>>>> On Wed, 17 May 2017 at 05:40 Ewen Cheslack-Postava < > >> e...@confluent.io > >>>>> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> +1 (binding) > >>>>>>>>> > >>>>>>>>> I mentioned this in the PR that triggered this: > >>>>>>>>> > >>>>>>>>>> KIP is accurate, though this is one of those things that we > should > >>>>>>>>> probably get a KIP for a standard set of config options across > all > >>>>>>> tools so > >>>>>>>>> additions like this can just fall under the umbrella of that > KIP... > >>>>>>>>> > >>>>>>>>> I think it would be great if someone wrote up a small KIP > providing > >>>>>>> some > >>>>>>>>> standardized settings that we could get future additions > >>>> automatically > >>>>>>>>> umbrella'd under, e.g. no need to do a KIP if just adding a > >>>>>>> consumer.config > >>>>>>>>> or consumer-property config conforming to existing expectations > for > >>>>>>> other > >>>>>>>>> tools. We could also standardize on a few other settings names > that > >>>> are > >>>>>>>>> inconsistent across different tools and set out a clear path > >> forward > >>>>>>> for > >>>>>>>>> future tools. > >>>>>>>>> > >>>>>>>>> I think I still have at least one open PR from when I first > started > >>>> on > >>>>>>> the > >>>>>>>>> project where I was trying to clean up some command line stuff to > >> be > >>>>>>> more > >>>>>>>>> consistent. This has been an issue for many years now... > >>>>>>>>> > >>>>>>>>> -Ewen > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On Tue, May 16, 2017 at 1:12 AM, Eno Thereska < > >>>> eno.there...@gmail.com> > >>>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>>> +1 thanks. > >>>>>>>>>> > >>>>>>>>>> Eno > >>>>>>>>>>> On 16 May 2017, at 04:20, BigData dev <bigdatadev...@gmail.com > > > >>>>>>> wrote: > >>>>>>>>>>> > >>>>>>>>>>> Hi All, > >>>>>>>>>>> Given the simple and non-controversial nature of the KIP, I > would > >>>>>>> like > >>>>>>>>> to > >>>>>>>>>>> start the voting process for KIP-157: Add consumer config > options > >>>> to > >>>>>>>>>>> streams reset tool > >>>>>>>>>>> > >>>>>>>>>>> *https://cwiki.apache.org/confluence/display/KAFKA/KIP+ > >>>>>>>>>> 157+-+Add+consumer+config+options+to+streams+reset+tool > >>>>>>>>>>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP+ > >>>>>>>>>> 157+-+Add+consumer+config+options+to+streams+reset+tool>* > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> The vote will run for a minimum of 72 hours. > >>>>>>>>>>> > >>>>>>>>>>> Thanks, > >>>>>>>>>>> > >>>>>>>>>>> Bharat > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>>> > >>> > >> > >> > > > >
