Thanks for the KIP. I think it makes sense to have those tags. My only question is regarding the compatibility impact. We don't have a good compatibility story when it comes to adding tags to existing metrics since the JmxReporter adds the tags to the object name.
Ismael On Thu, Mar 30, 2017 at 4:51 PM, Edoardo Comar <eco...@uk.ibm.com> wrote: > Hi all, > > We created KIP-136: Add Listener name and Security Protocol name to > SelectorMetrics tags > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 136%3A+Add+Listener+name+and+Security+Protocol+name+to+ > SelectorMetrics+tags > > Please help review the KIP. You feedback is appreciated! > > cheers, > Edo > -------------------------------------------------- > Edoardo Comar > IBM MessageHub > eco...@uk.ibm.com > IBM UK Ltd, Hursley Park, SO21 2JN > > IBM United Kingdom Limited Registered in England and Wales with number > 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 > 3AU > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >
