While coding I thought of a slight deviation from the KIP screenshots. That is, adding the listener tag only if it differs from protocol. So in most common cases we won't see PLAINTEXT-PLAINTEXT, SSL-SSL etc
I should have offered this option while discussing the KIP. Any late ppinions? Edo -------------------------------------------------- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN From: Edoardo Comar/UK/IBM@IBMGB To: dev@kafka.apache.org Date: 03/05/2017 03:00 Subject: Re: [DISCUSS] KIP-136: Add Listener name and Security Protocol name to SelectorMetrics tags Thanks Ismael, I meant for this change to only apply to brokers, not clients, I'm going to update the KIP -------------------------------------------------- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU From: Ismael Juma <ism...@juma.me.uk> To: dev@kafka.apache.org Date: 02/05/2017 20:20 Subject: Re: [DISCUSS] KIP-136: Add Listener name and Security Protocol name to SelectorMetrics tags Sent by: isma...@gmail.com Edoardo, Are you planning to do this only in the broker? Listener names only exist at the broker level. Also, clients only have a single security protocol, so maybe we should do this for brokers only. In that case, the compatibility impact is also lower because more users rely on the Yammer metrics instead. I would suggest you start the voting thread after clarifying if this change only applies at the broker level. Ismael On Tue, Apr 25, 2017 at 1:19 PM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks for the KIP. I think it makes sense to have those tags. My only > question is regarding the compatibility impact. We don't have a good > compatibility story when it comes to adding tags to existing metrics since > the JmxReporter adds the tags to the object name. > > Ismael > > On Thu, Mar 30, 2017 at 4:51 PM, Edoardo Comar <eco...@uk.ibm.com> wrote: > >> Hi all, >> >> We created KIP-136: Add Listener name and Security Protocol name to >> SelectorMetrics tags >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-136% >> 3A+Add+Listener+name+and+Security+Protocol+name+to+SelectorMetrics+tags >> >> Please help review the KIP. You feedback is appreciated! >> >> cheers, >> Edo >> -------------------------------------------------- >> Edoardo Comar >> IBM MessageHub >> eco...@uk.ibm.com >> IBM UK Ltd, Hursley Park, SO21 2JN >> >> IBM United Kingdom Limited Registered in England and Wales with number >> 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 >> 3AU >> Unless stated otherwise above: >> IBM United Kingdom Limited - Registered in England and Wales with number >> 741598. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >> > > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
