Hi Stephane, Thanks for the KIP. Overall it looks ok, though i think the builder should enforce the required parameters by supplying them via the constructor, i.e,
public ProducerRecordBuilder(String topic, V value) You can then remove the withValue and withTopic methods I also think withForcedPartition should just be withPartition Thanks, Damian On Wed, 19 Apr 2017 at 23:34 Stephane Maarek <steph...@simplemachines.com.au> wrote: > Hi all, > > My first KIP, let me know your thoughts! > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+141+-+ProducerRecordBuilder+Interface > > > Cheers, > Stephane >
