[
https://issues.apache.org/jira/browse/KAFKA-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906073#comment-15906073
]
ASF GitHub Bot commented on KAFKA-4882:
---------------------------------------
GitHub user mitch-seymour opened a pull request:
https://github.com/apache/kafka/pull/2675
KAFKA-4882: Remove internal converter configuration from example property
files
Connect works best with the default JSON converters, and exposing the
internal converter config tempts users to change it (see
[KAFKA-4882](https://issues.apache.org/jira/browse/KAFKA-4882) for more info).
Also, I don't really see how `internal.key.converter.schemas.enable` ever
gets used. I see some tests specifying this value but don't see anything in
`org.apache.kafka.connect.runtime.WorkerConfig` or anywhere else (maybe I'm
just missing it?).
Anyways, this is my first commit, hope it's okay :)
This contribution is my original work and I license the work to the project
under the project's open source license.
cc @gwenshap @ewencp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitch-seymour/kafka KAFKA-4882
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2675
----
commit 471be6d08b3004cabce3e89a5aec7fc7de9ec07b
Author: Mitch Seymour <mitchseym...@gmail.com>
Date: 2017-03-11T03:53:52Z
KAFKA-4882: Remove internal converter configuration from example property
files
----
> Remove internal converter configuration from example property files
> -------------------------------------------------------------------
>
> Key: KAFKA-4882
> URL: https://issues.apache.org/jira/browse/KAFKA-4882
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Mitch Seymour
> Labels: newbie
>
> Our internal converter configuration is shown in
> connect-distributed.properties and connect-standalone.properties.
> This tempts users to change it.
> In particular, they seem to believe it needs to be identical to key/value
> converters.
> In reality, Connect doesn't deal well with anything other than schemaless
> JSON as the internal converter. Users get errors and find it hard to figure
> out what went wrong (since this is internal, they are not expected to).
> Let's stop tempting users into shooting their own feet?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
