GitHub user mitch-seymour opened a pull request:
https://github.com/apache/kafka/pull/2675
KAFKA-4882: Remove internal converter configuration from example property
files
Connect works best with the default JSON converters, and exposing the
internal converter config tempts users to change it (see
[KAFKA-4882](https://issues.apache.org/jira/browse/KAFKA-4882) for more info).
Also, I don't really see how `internal.key.converter.schemas.enable` ever
gets used. I see some tests specifying this value but don't see anything in
`org.apache.kafka.connect.runtime.WorkerConfig` or anywhere else (maybe I'm
just missing it?).
Anyways, this is my first commit, hope it's okay :)
This contribution is my original work and I license the work to the project
under the project's open source license.
cc @gwenshap @ewencp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitch-seymour/kafka KAFKA-4882
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2675
----
commit 471be6d08b3004cabce3e89a5aec7fc7de9ec07b
Author: Mitch Seymour <[email protected]>
Date: 2017-03-11T03:53:52Z
KAFKA-4882: Remove internal converter configuration from example property
files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
