[
https://issues.apache.org/jira/browse/KAFKA-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880409#comment-15880409
]
ASF GitHub Bot commented on KAFKA-4788:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2588
KAFKA-4788: Revert "KAFKA-4092: retention.bytes should not be allowed to be
less than segment.bytes"
The intent is good, but it needs to take into account broker configs as
well.
See KAFKA-4788 for more details.
This reverts commit 4ca5abe8ee7578f602fb7653cb8a09640607ea85.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka kafka-4788
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2588
----
commit 56c197a904dbf7549534f6589e062c61e17e47b5
Author: Ismael Juma <[email protected]>
Date: 2017-02-23T13:19:06Z
Revert "KAFKA-4092: retention.bytes should not be allowed to be less than
segment.bytes"
The intent is good, but it needs to take into account broker configs as
well.
See KAFKA-4788 for more details.
This reverts commit 4ca5abe8ee7578f602fb7653cb8a09640607ea85.
----
> Broker level configuration 'log.segment.bytes' not used when 'segment.bytes'
> not configured per topic.
> ------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-4788
> URL: https://issues.apache.org/jira/browse/KAFKA-4788
> Project: Kafka
> Issue Type: Bug
> Components: log
> Affects Versions: 0.10.2.0
> Reporter: Ciprian Pascu
> Labels: regression
> Fix For: 0.10.3.0, 0.10.2.1
>
>
> In the previous version, if there was not topic level configuration
> 'segment.bytes', then the corresponding value from the broker configuration
> was used (for 'segment.bytes', this is the value configured for
> 'log.segment.bytes'); in 0.10.2.0, if the configuration at topic level is
> missing, then the value configured at broker level is not used, some kind of
> default value for that broker level configuration is used (for
> 'log.retention.bytes', this is 'val LogSegmentBytes = 1 * 1024 * 1024 *
> 1024').
> However, in the documentation it is said: 'A given server default config
> value only applies to a topic if it does not have an explicit topic config
> override.'; so, according to this, if there is, for example, no value
> configured for 'segment.bytes', then the value configured for
> 'log.segment.bytes' should be used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
