Looks good. +1 (non-binding). What do you think about changing "protocol label" to "listener key"?
best, Colin On Fri, Jan 6, 2017, at 09:23, Neha Narkhede wrote: > +1 > > On Fri, Jan 6, 2017 at 9:21 AM Jun Rao <j...@confluent.io> wrote: > > > Hi, Ismael, > > > > Thanks for the KIP. +1 > > > > Jun > > > > On Fri, Jan 6, 2017 at 2:51 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > Hi all, > > > > > > As the discussion seems to have settled down, I would like to initiate > > the > > > voting process for KIP-103: Separation of Internal and External traffic: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 103%3A+Separation+of+Internal+and+External+traffic > > > > > > The vote will run for a minimum of 72 hours. > > > > > > Thanks, > > > Ismael > > > > > > -- > Thanks, > Neha
