[ https://issues.apache.org/jira/browse/KAFKA-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242488#comment-15242488 ]
Guozhang Wang commented on KAFKA-3549: -------------------------------------- This reminds me of KAFKA-1501 again.. BTW for all those tests you mentioned above, I feel they should really be in system tests, not in unit tests anyways. Admittedly they will make Jenkins validations weaker as we only run system tests nightly, but today these tests in Jenkins have been more than pain than a safety net for us. > Close consumers instantiated in consumer tests > ---------------------------------------------- > > Key: KAFKA-3549 > URL: https://issues.apache.org/jira/browse/KAFKA-3549 > Project: Kafka > Issue Type: Improvement > Reporter: Grant Henke > Assignee: Grant Henke > Fix For: 0.10.1.0 > > > Close consumers instantiated in consumer tests. Since these consumers often > use the default group.id of "", they could cause transient failures like > those seen in KAFKA-3117 and KAFKA-2933. I have not been able to prove that > this change will fix those failures, but closing the consumers is a good > practice regardless. -- This message was sent by Atlassian JIRA (v6.3.4#6332)