[
https://issues.apache.org/jira/browse/KAFKA-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237803#comment-15237803
]
ASF GitHub Bot commented on KAFKA-3549:
---------------------------------------
GitHub user granthenke opened a pull request:
https://github.com/apache/kafka/pull/1217
KAFKA-3549: Close consumers instantiated in consumer tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/granthenke/kafka close-consumers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1217
----
commit 0008c9dc4495bd8830d5245350a3dd61807d8c21
Author: Grant Henke <granthe...@gmail.com>
Date: 2016-04-12T19:08:50Z
KAFKA-3549: Close consumers instantiated in consumer tests
----
> Close consumers instantiated in consumer tests
> ----------------------------------------------
>
> Key: KAFKA-3549
> URL: https://issues.apache.org/jira/browse/KAFKA-3549
> Project: Kafka
> Issue Type: Improvement
> Reporter: Grant Henke
> Assignee: Grant Henke
>
> Close consumers instantiated in consumer tests. Since these consumers often
> use the default group.id of "", they could cause transient failures like
> those seen in KAFKA-3117 and KAFKA-2933. I have not been able to prove that
> this change will fix those failures, but closing the consumers is a good
> practice regardless.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
